asbachb commented on PR #5482: URL: https://github.com/apache/netbeans/pull/5482#issuecomment-1435437474
@mbien I know the code is and was not optimal. The multi threaded detection is not very robust. On the other hand that PR makes the standard use case (don't configure any threading manually) somehow workable. So from my point of view for now it's more important that multi modules give some output at all than having a nice output for single module projects. > what happens if -T 1 is set and isMultiThreaded is updated to return false, can event spy be used in multi module projects? I don't know tbh. Based on the previous code I'd say: no. As it was disabled on purpose. > does the builder type in use influence anything (probably not) What do you mean by "builder type"? > is there an easy way for MavenCommandLineExecutor to detect if the project is single module? From my understanding the `pom.xml` is parsed and put into maven api objects. When we could access that `pom.xml` representation from `MavenCommandLineExecutor` and evaluate if it contains modules. Final note: The output when running `mvnd` with multiple threads in NetBeans is not really helpful as it's mixed all over the place. When executing `mvnd` from console the output updates and after compilation consolidated log is printed (if I remember correctly it's also sorted by module). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
