mbien commented on PR #5417: URL: https://github.com/apache/netbeans/pull/5417#issuecomment-1435646548
hi @vieiro, platform should be enough here (harness stuff is hooked to the platform jobs). But your intuition is right, when in doubt -> all tests. to make CI pick up the labeling change however we have to create a fresh workflow run via a PR sync or the "lock/unlock conversation" button on the right which we use as workaround in situations like here to get a new workflow. Pressing approve will start the *old* workflow run (!). I sometimes go to https://github.com/apache/netbeans/actions directly and remove the old workflow run first to not cause confusion which also removes the button. > added new tests as the existing ones are just smoke tests which do not verify much the intention is to remove existing ones in next PR hi @lbownik. Please leave the old tests there, you basically wrote tests for a facade while the other tests, although rudimentary on the surface, actually test the implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
