matthiasblaesing commented on code in PR #5173:
URL: https://github.com/apache/netbeans/pull/5173#discussion_r1111316734
##########
java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/UnusedDetector.java:
##########
@@ -597,5 +619,49 @@ private void handleDeclaration(TreePath path) {
}
}
}
+
+ @Override
+ public Void visitLiteral(LiteralTree node, Void p) {
+ if (node.getKind() == Kind.STRING_LITERAL) {
+ allStringLiterals.add((String) ((LiteralTree)
node).getValue());
Review Comment:
Think you for the explanation. With that in mind it makes sense to me. I
overlooked the combined effect of:
https://github.com/apache/netbeans/pull/5173/files/7c57e4b4d7faf2b094e67ffab43100182f4f45bb#diff-908c30e8d355bd77779d4bfffcd966667091f27f2ab26299889fcceb659478c6R643-R662
and
https://github.com/apache/netbeans/pull/5173/files/7c57e4b4d7faf2b094e67ffab43100182f4f45bb#diff-908c30e8d355bd77779d4bfffcd966667091f27f2ab26299889fcceb659478c6R297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
