junichi11 commented on code in PR #5534:
URL: https://github.com/apache/netbeans/pull/5534#discussion_r1111429941
##########
php/php.editor/src/org/netbeans/modules/php/editor/verification/UnusableTypesHintError.java:
##########
@@ -430,18 +430,15 @@ private void checkDuplicateType(List<Expression> types) {
}
if (checkedTypes.contains(name)) {
createDuplicateTypeError(type, typeName);
- return;
Review Comment:
I've added it for a little performance (because the next error is shown if
the error is fixed) but I don't think this fix has a big problem. So, it's OK.
##########
php/php.editor/src/org/netbeans/modules/php/editor/verification/UnusableTypesHintError.java:
##########
@@ -430,18 +430,15 @@ private void checkDuplicateType(List<Expression> types) {
}
if (checkedTypes.contains(name)) {
createDuplicateTypeError(type, typeName);
- return;
} else if (checkedTypes.contains(Type.BOOL)) {
// bool|false bool|true
if (Type.FALSE.equals(name) || Type.TRUE.equals(name)) {
createDuplicateTypeError(type, typeName);
- return;
Review Comment:
Unit tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
