mbien commented on code in PR #5530:
URL: https://github.com/apache/netbeans/pull/5530#discussion_r1117947586
##########
enterprise/web.monitor/serversrc/org/netbeans/modules/web/monitor/server/MonitorFilter.java:
##########
@@ -587,7 +587,7 @@ else if(debug) {
return;
}
- StringBuffer buf =
+ StringBuffer buf =
new StringBuffer(monData.getAttributeValue("id")); //NOI18N
Review Comment:
curious whitespace change, potentially meant to change this to
`StringBuilder`?
##########
enterprise/web.monitor/serversrc/org/netbeans/modules/web/monitor/server/NotifyUtil.java:
##########
@@ -117,28 +119,32 @@ void setIDE(String server) throws MalformedURLException {
}
void sendRecord(MonitorData monData, String queryStr) {
-
- if(debug) log("NotifyUtil::notifyServer"); //NOI18N
-
- if(ideServer != null) {
- String urlStr = ideServer.concat(queryStr);
- if(debug) log("NotifyUtil: url is " + urlStr); //NOI18N
- sendRecord(urlStr, monData);
- }
-
- if(otherIDEs.isEmpty()) return;
-
- Enumeration ides = otherIDEs.elements();
- while(ides.hasMoreElements()) {
-
- String base = (String)ides.nextElement();
-
- if(debug)
- log("NotifyUtil: url is " + base.concat(queryStr)); //NOI18N
- if(!sendRecord(base.concat(queryStr), monData))
- otherIDEs.remove(base);
- }
- return;
+ try {
+ if(debug) log("NotifyUtil::notifyServer"); //NOI18N
+
+ if(ideServer != null) {
+ String urlStr =
ideServer.concat(URLEncoder.encode(queryStr, "UTF-8")); //NOI18N
+ if(debug) log("NotifyUtil: url is " + urlStr); //NOI18N
+ sendRecord(urlStr, monData);
+ }
Review Comment:
some indentation issues here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
