matthiasblaesing commented on PR #5567:
URL: https://github.com/apache/netbeans/pull/5567#issuecomment-1445439720

   @vieiro minimal nitpicks to get this compiling:
   
   ```diff
   matthias@enterprise:~/src/netbeans$ git diff                                 
                                                                                
                                               
   diff --git a/nbbuild/cluster.properties b/nbbuild/cluster.properties
   index 4a2094455678..9bda205fd9a4 100644
   --- a/nbbuild/cluster.properties
   +++ b/nbbuild/cluster.properties
   @@ -51,6 +51,7 @@ clusters.config.full.list=\
            nb.cluster.cpplite,\
            nb.cluster.groovy,\
            nb.cluster.php,\
   +        nb.cluster.rust,\
            ${clusters.config.standard.list},\
            nb.cluster.ergonomics
    # ergonomics must be last
   diff --git a/rust/rust.project/nbproject/project.xml 
b/rust/rust.project/nbproject/project.xml
   index b8d07ca1ed06..5a0d8e6094d4 100644
   --- a/rust/rust.project/nbproject/project.xml
   +++ b/rust/rust.project/nbproject/project.xml
   @@ -168,11 +168,6 @@
                        </run-dependency>
                    </dependency>
                </module-dependencies>
   -            <test-dependencies>
   -                <test-type>
   -                    <name>unit</name>
   -                </test-type>
   -            </test-dependencies>
                <public-packages>
                    <package>org.netbeans.modules.rust.project.api</package>
                </public-packages>
   matthias@enterprise:~/src/netbeans$ 
   ```
   
   My understanding on the usage of `clusters.config.full.list` is, that it is 
used as the basis to find all modules, the dependencies and enumerate all 
clusters. This at least I read into the code present in `nbbuild`.
   
   The second change present above is to fix the build complaining about a 
project without test code having test dependencies.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to