vieiro commented on PR #5598: URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1454847993
I added some quick reviews. A more thorough review will take much more time. In this quick review, I've seen that: - You correct some typos in internal variables, some documentation and elsewhere. - You modify tests without really testing them (you say "BUILD SUCCESSFUL", but not "ALL TESTS OK"). - You modify diff files. - You change public APIs/SPIs. - This requires reviewer's time. You have to understand that "Build successful" is not enough. You have to build, test and possibly run things before submitting the PRs, because we don't have time to spend reviewing hundreds of changes to files that break our tests and make our APIs backwards incompatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
