vieiro commented on code in PR #5598: URL: https://github.com/apache/netbeans/pull/5598#discussion_r1129941856
########## php/php.editor/test/unit/data/testfiles/completion/lib/nb1855/nb1855.php.testCompleteAccessPrefixInClassConst_01.completion: ########## @@ -6,8 +6,8 @@ CLASS ParentClass [PUBLIC] nb1855.php CONSTANT PRIVATE_CONSTANT "private cons [PRIVATE] Class1855 CONSTANT PROTECTED_CONSTANT "protected [PROTECTE Class1855 CONSTANT PROTECTED_PARENT_CONSTANT "pro [PROTECTE ParentClass -CONSTANT PUBLIC_CONSTANT "pubic constan [PUBLIC] Class1855 -CONSTANT PUBLIC_PARENT_CONSTANT "pubic [PUBLIC] ParentClass +CONSTANT PUBLIC_CONSTANT "public consta [PUBLIC] Class1855 +CONSTANT PUBLIC_PARENT_CONSTANT "public [PUBLIC] ParentClass Review Comment: So you're changing a ".completion" test file. Questions: 1) Can you explain how these completion test work? 2) Does this module pass an `ant test` after this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
