jtulach commented on PR #5609: URL: https://github.com/apache/netbeans/pull/5609#issuecomment-1465276210
> Further idea: My reading of the module system is, that it should be possible to selectively upgrade parts of the JDK runtime (see `--upgrade-module-path` option). That way "nb-javac" would just "be" `jdk.compiler`. No fiddling with the build environment necessary. The drawback is: the`nb-javac` is not used that way in NetBeans. NetBeans is using similar "classloader trick" with [masking JDK classes](https://github.com/apache/netbeans/blob/c8de82fc93cc1dee8b385e77f1aa7352d6eecec8/java/libs.nbjavacapi/manifest.mf#L6). If we succeed with `--upgrade-module-path` option - it may not guarantee `nb-javac` works in NetBeans properly. Btw. I wanted to "Eat our own dog food" with `nb-javac@19`, but I couldn't as https://github.com/JaroslavTulach/nb-javac/pull/11 - we wouldn't found that problem with `--upgrade-module-path` option. While [real JDK test](https://github.com/JaroslavTulach/nb-javac/blob/1c6acf4c26172973075d4027ca39a36c063ad43b/build-jdk.sh#L99) is also useful check, for NetBeans I'd rather stick with old good "classloader trick". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
