pepness commented on code in PR #4687:
URL: https://github.com/apache/netbeans/pull/4687#discussion_r1136417925
##########
enterprise/glassfish.javaee/src/org/netbeans/modules/glassfish/javaee/Hk2JpaSupportImpl.java:
##########
@@ -97,10 +109,12 @@ private static class JpaSupportVector {
static {
for (GlassFishVersion version : GlassFishVersion.values()) {
jpaSupport[version.ordinal()] = new JpaSupportVector(
- GlassFishVersion.lt(version, GlassFishVersion.GF_6),
- GlassFishVersion.lt(version, GlassFishVersion.GF_6) &&
GlassFishVersion.ge(version, GlassFishVersion.GF_3),
- GlassFishVersion.lt(version, GlassFishVersion.GF_6) &&
GlassFishVersion.ge(version, GlassFishVersion.GF_4),
- GlassFishVersion.lt(version, GlassFishVersion.GF_6) &&
GlassFishVersion.ge(version, GlassFishVersion.GF_5)
+ GlassFishVersion.lt(version, GlassFishVersion.GF_7_0_0),
+ GlassFishVersion.lt(version, GlassFishVersion.GF_7_0_0) &&
GlassFishVersion.ge(version, GlassFishVersion.GF_3),
+ GlassFishVersion.lt(version, GlassFishVersion.GF_7_0_0) &&
GlassFishVersion.ge(version, GlassFishVersion.GF_4),
+ GlassFishVersion.lt(version, GlassFishVersion.GF_7_0_0) &&
GlassFishVersion.ge(version, GlassFishVersion.GF_5),
Review Comment:
JPA 1.0, 2.0, 2.1 and 2.2 are not supported by GlassFish 6 and upward, so
the comparison for JPA below 3.0 should be against `GlassFishVersion.GF_6`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
