mbien commented on code in PR #5679:
URL: https://github.com/apache/netbeans/pull/5679#discussion_r1141271688
##########
java/maven/src/org/netbeans/modules/maven/execute/MavenProxySupport.java:
##########
@@ -935,7 +949,11 @@ public int next() throws XmlPullParserException,
IOException {
private LineAndColumn startPos() {
int ln = getLineNumber();
int col = getColumnNumber();
- col -= (posEnd - posStart);
+ try {
+ col -= (posEndField.getInt(this) - posStartField.getInt(this));
+ } catch (IllegalAccessException ex) {
+ Exceptions.printStackTrace(ex);
+ }
Review Comment:
this is ugly, those fields are now private since
https://github.com/codehaus-plexus/plexus-utils/commit/797cab4d0fb5ce88ef6863cc504f929f6978ff95
##########
java/maven.indexer/src/org/netbeans/modules/maven/indexer/NexusRepositoryIndexerImpl.java:
##########
@@ -526,13 +526,13 @@ private void indexLoadedRepo(final RepositoryInfo repo,
boolean updateLocal) thr
}
// MINDEXER-42: cannot use
WagonHelper.getWagonResourceFetcher
Wagon wagon = embedder.lookup(Wagon.class, protocol);
- if (wagon instanceof HttpWagon) { //#216401
- HttpWagon httpwagon = (HttpWagon) wagon;
- //#215343
- Properties p = new Properties();
- p.setProperty("User-Agent", "netBeans/" +
System.getProperty("netbeans.buildnumber"));
- httpwagon.setHttpHeaders(p);
- }
+// if (wagon instanceof HttpWagon) { //#216401
+// HttpWagon httpwagon = (HttpWagon) wagon;
+// //#215343
+// Properties p = new Properties();
+// p.setProperty("User-Agent", "netBeans/" +
System.getProperty("netbeans.buildnumber"));
+// httpwagon.setHttpHeaders(p);
+// }
Review Comment:
todo: investigate build error
```
/home/mbien/NetBeansProjects/netbeans/java/maven.indexer/src/org/netbeans/modules/maven/indexer/NexusRepositoryIndexerImpl.java:529:
error: cannot access AbstractHttpClientWagon
if (wagon instanceof HttpWagon) { //#216401
class file for org.apache.maven.wagon.shared.http.AbstractHttpClientWagon
not found
```
some class moved probably. Could be done via reflection since it is just a
method and overall not so important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
