matthiasblaesing commented on PR #5694: URL: https://github.com/apache/netbeans/pull/5694#issuecomment-1481179405
@jtulach thank for looking into this and no reason to apologize. The current code that is proposed to be integrated here has already an outside history, ontop of your work. I looked into the divergence between the upstream graaljs and the version you thankfully created and faced to much for me to handle. So I created my own fork (https://github.com/matthiasblaesing/graaljs-nb) and modified the parser in a manor I could manage to support new JS features. This was also motivated by the fact, that graaljs upstream does not support JSX and thus a move fully to upstream would kill that feature in NetBeans. We can try to get the fork more in-line with upstream again and reduce differences, but I don't see us switching back to upstream again. So I agree with you and @vieiro, that better alignment would be good, I also have to be realistic what I can archive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
