tmysik commented on code in PR #5720:
URL: https://github.com/apache/netbeans/pull/5720#discussion_r1148477192
##########
php/php.editor/src/org/netbeans/modules/php/editor/csl/SemanticAnalysis.java:
##########
@@ -819,6 +820,12 @@ public void visit(ConstantDeclaration node) {
if (!isPrivate || parentNode instanceof TraitDeclaration) {
addColoringForNode(identifier, coloring);
} else {
+ // NOTE: private constants, methods, and fields may be
used in traits
+ // currently, we don't check traits (if there is no
performance problem, should check them if possible)
+ // an enum is handled as a "final" class in PHP
+ // so, virtually, "protected" is "private"
+ // however, as wrote above, it may be used in traits
Review Comment:
```suggestion
// however, as written above, it may be used in
traits
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
