sdedic commented on PR #5671:
URL: https://github.com/apache/netbeans/pull/5671#issuecomment-1484057282
> Looks sane to me. I don't think this is strictly an API change - the
documented change is not part of the exposed API,
I'ts not, but the `spiimpl` package is a semi-api (or this is how it is used
by other hint modules).
> I also think some methods could have lower visibility (for example
`openRefactoringUI`), but as this is not API, I think it is ok.
Please elaborate. Speaking about
`org.netbeans.modules.java.hints.spiimpl.Utilities::openRecatoringUI` - the
intention was to expose a helper ("api") method that would locate & call the
plugged SPI implementation or fail; the method is likely to be called from
different packages, hence it should be public ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
