neilcsmith-net commented on PR #5609: URL: https://github.com/apache/netbeans/pull/5609#issuecomment-1484154347
Thanks @matthiasblaesing Couple of comments, in priority order. > Only run the nbjavac test job when the Java label is added to the PR. Can we please add a `nb-javac` label and only run the test on that, not every Java labelled PR as per https://github.com/apache/netbeans/pull/5609#issuecomment-1476006761 > `loadClass` is not synchronized and does not synchronize access to the caching `HashMap`. Instead of introducing synchronization, use a thread safe `ConcurrentHashMap`. Also use `computeIfAbsent()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
