junichi11 commented on code in PR #5731:
URL: https://github.com/apache/netbeans/pull/5731#discussion_r1151852285
##########
php/php.editor/src/org/netbeans/modules/php/editor/indent/FmtOptions.java:
##########
@@ -288,7 +288,7 @@ private static void createDefaults() {
{BLANK_LINES_BEFORE_CLASS, "1"}, //NOI18N
{BLANK_LINES_AFTER_CLASS, "1"}, //NOI18N
{BLANK_LINES_AFTER_CLASS_HEADER, "0"}, //NOI18N
- {BLANK_LINES_BEFORE_CLASS_END, "0"}, //NOI18N
+ {BLANK_LINES_BEFORE_CLASS_END, "1"}, //NOI18N
Review Comment:
Ah, I see now.
I'll revert this PR to my first commit :)
> I am sorry for not being clear enough in my first comment
No problem :)
#### Example
```php
class GH4611Class {
private int $field;
public function method1() {
}
}
```
#### CLASS_END: 0
Existing behavior is changed by default options
Before PR by default options
```php
class GH4611Class {
private int $field;
public function method1() {
}
}
```
After PR by default options
```php
class GH4611Class {
private int $field;
public function method1() {
}
}
```
#### CLASS_END: 1
Existing behavior is keeped by default options
Before PR by default options
```php
class GH4611Class {
private int $field;
public function method1() {
}
}
```
After PR by default options
```php
class GH4611Class {
private int $field;
public function method1() {
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
