tmysik commented on code in PR #5745:
URL: https://github.com/apache/netbeans/pull/5745#discussion_r1153574010
##########
php/php.editor/src/org/netbeans/modules/php/editor/model/impl/ClassScopeImpl.java:
##########
@@ -335,6 +336,13 @@ public Collection<? extends FieldElement>
getInheritedFields() {
allFields.add(new FieldElementImpl(traitScope, field));
}
}
+ // GH-4683 get fields of mixin
+ Set<TypeMemberElement> mixinTypeMembers =
index.getAccessibleMixinTypeMembers(this, this);
+ for (TypeMemberElement mixinTypeMember : mixinTypeMembers) {
+ if (mixinTypeMember instanceof
org.netbeans.modules.php.editor.api.elements.FieldElement) {
+ allFields.add((new FieldElementImpl(this,
(org.netbeans.modules.php.editor.api.elements.FieldElement) mixinTypeMember)));
+ }
Review Comment:
I tend to agree - streams are nice and useful for simple things. But quite
difficult to debug in case of problems 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
