sdedic commented on code in PR #5781:
URL: https://github.com/apache/netbeans/pull/5781#discussion_r1159764742
##########
java/maven/src/org/netbeans/modules/maven/modelcache/MavenProjectCache.java:
##########
@@ -364,11 +411,16 @@ public static MavenProject getFallbackProject(File
projectFile) throws Assertion
newproject.setName(Bundle.LBL_Incomplete_Project_Name());
newproject.setDescription(Bundle.LBL_Incomplete_Project_Desc());
newproject.setFile(projectFile);
+ newproject.setContextValue(CONTEXT_FALLBACK_PROJECT, true);
return newproject;
}
public static boolean isFallbackproject(MavenProject prj) {
- return "error".equals(prj.getGroupId()) &&
"error".equals(prj.getArtifactId()) &&
Bundle.LBL_Incomplete_Project_Name().equals(prj.getName());
+ if ("error".equals(prj.getGroupId()) &&
"error".equals(prj.getArtifactId()) &&
Bundle.LBL_Incomplete_Project_Name().equals(prj.getName())) {
Review Comment:
`org.apache.maven.project.MavenProject` is not part of NetBeans project. I
need some utility place to put this helper in; maybe the cache is not the best
place -- will solve in subsequent PR with 'more appropriate fix' described at
the top.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
