junichi11 commented on code in PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#discussion_r1159993313
##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/DocRenderer.java:
##########
@@ -608,9 +608,12 @@ private String composeType(Collection<TypeResolver> types,
Type.Kind typeKind) {
if (type.isResolved()) {
QualifiedName typeName = type.getTypeName(true);
if (typeName != null) {
- if (sb.length() > 0
- && (typeKind == Type.Kind.UNION || typeKind ==
Type.Kind.INTERSECTION)) {
- sb.append(" ").append(typeKind.getSign()).append("
"); // NOI18N
+ if (sb.length() > 0) {
+ if (typeKind == Type.Kind.INTERSECTION) {
+ sb.append("
").append(typeKind.getSign()).append(" "); // NOI18N
+ } else {
+ sb.append("
").append(Type.Kind.UNION.getSign()).append(" "); // NOI18N
Review Comment:
> it is always a union. Or is it not so?
Well... not so. PHP 8.2 has DNF type. Please wait a while because I'll
improve it. (I have not finished implementing it yet.)
I would do the above because we can see that the `else` part is not a case
of normal union type. Your change is also no problem, of course. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
