mbien commented on PR #5739: URL: https://github.com/apache/netbeans/pull/5739#issuecomment-1500474217
there is also no requirement to have a PR produce a single commit. Sometimes it is better to separate things which don't belong together in one commit. So you force push into the branch to produce the cleaned up history, then you merge as is. I personally find it rarely useful to go through the commit history in PRs (unless it has been cleaned up). Commits like "implemented review requests" have mostly only temporary value to communicate with other reviewers while the review is going on. Once its is reviewed, all what counts are the resulting commits (or single commit as in this case). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
