mbien commented on code in PR #5753:
URL: https://github.com/apache/netbeans/pull/5753#discussion_r1165758074
##########
apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/NbmWizardIterator.java:
##########
@@ -145,11 +149,11 @@ public Set<FileObject> instantiate() throws IOException {
Map<String,String> additional =
Collections.singletonMap("netbeansVersion", version); // NOI18N
if (archetype == NB_MODULE_ARCH) {
- getLatestArchetypeVersion(NB_MODULE_ARCH);
+ updateToLatestKnownArchetypeVersion(NB_MODULE_ARCH);
NBMNativeMWI.instantiate(vi, projFile, version,
Boolean.TRUE.equals(wiz.getProperty(OSGIDEPENDENCIES)), null);
} else {
- getLatestArchetypeVersion(NB_APP_ARCH);
+ updateToLatestKnownArchetypeVersion(NB_APP_ARCH);
ArchetypeWizards.createFromArchetype(projFile, vi, archetype,
additional, true);
Review Comment:
ah ok. So lets keep it as is for now, but we should probably change it so
that both wizards use the archetypes (via
`ArchetypeWizards.createFromArchetype()`). Right now its two entirely different
code paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
