sdedic commented on code in PR #5842:
URL: https://github.com/apache/netbeans/pull/5842#discussion_r1170808425
##########
harness/nbjunit/src/org/netbeans/junit/NbTestCase.java:
##########
@@ -474,6 +476,8 @@ public synchronized void waitFinished(final int timeout)
throws Throwable {
long now = System.nanoTime();
try {
runTest();
+ } catch (AssumptionViolatedException ex) {
+ // ignore, the test is assumed to be meaningless.
Review Comment:
Sadly - I didn't come with a way how to mark it skipped, here in
JUnit3-style code. The actual `TestResutl` that came around at runtime only
allowed to mark the test passed/failed/error. I am not particularly happy with
marking skipped as passing but better than failure.
An option would be to rewrite all those `assume` statements to if-returns.
Please suggest / elaborate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
