neilcsmith-net commented on PR #5867: URL: https://github.com/apache/netbeans/pull/5867#issuecomment-1520434334
> > This does change the default blue to be much darker than the existing hardcoded colour though. > > But only for FlatLaf Light. Other L&Fs (FlatLaf Dark, Windows, Nimbus, etc) are not changed. > > To keep the light blue selection color, you could add following to `FlatLightLaf.properties`: > > ```ini > nb.options.categories.selectionBackground = tint(@selectionBackground,70%) > nb.options.categories.selectionForeground = @foreground > ``` Thanks for the review! Yes, should have made it clear that that only affects the default L&F (ie. FlatLaf Light). The point underneath it about `Tree,selectionForeground` is the only bit that could affect other L&Fs. I did consider doing what you suggested, but thought there was some benefit to keeping the light and dark settings consistent and in one place (given the other issue that triggered this!). I'll merge as is for now, but have no strong preference either way if you want to add those overrides into the light theme. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
