tmysik commented on code in PR #5885:
URL: https://github.com/apache/netbeans/pull/5885#discussion_r1176494236
##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCodeCompletion.java:
##########
@@ -335,7 +335,9 @@ public CodeCompletionResult complete(CodeCompletionContext
completionContext) {
// GH-4494 if query type is documentation, get a whole identifier as a
prefix
boolean upToOffset = queryType != QueryType.DOCUMENTATION;
prefix = getPrefix(info, caretOffset, upToOffset,
PrefixBreaker.WITH_NS_PARTS);
+ String prefixUntilCaret = getPrefix(info, caretOffset, true,
PrefixBreaker.WITH_NS_PARTS); // GH-5881
Review Comment:
If `upToOffset` is `true`, we can skip this call and use `prefix` directly,
no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
