junichi11 commented on code in PR #5900:
URL: https://github.com/apache/netbeans/pull/5900#discussion_r1188078689
##########
php/php.editor/src/org/netbeans/modules/php/editor/actions/FixUsesPerformer.java:
##########
@@ -631,13 +757,221 @@ private int getOffsetWithoutLeadingWhitespaces(final int
startOffset) {
return result;
}
+ private int getOffsetWithoutFollowingWhitespaces(final int endOffset) {
+ int result = endOffset;
+ baseDocument.readLock();
+ try {
+ TokenSequence<PHPTokenId> ts =
LexUtilities.getPHPTokenSequence(baseDocument, endOffset);
+ if (ts != null) {
+ ts.move(endOffset);
+ while (ts.moveNext() &&
ts.token().id().equals(PHPTokenId.WHITESPACE)) {
+ result = ts.offset() + ts.token().length();
+ }
+ }
+ } finally {
+ baseDocument.readUnlock();
+ }
+ return result;
+ }
+
+ private class UsesInsertStringHelper {
Review Comment:
I agree with @tmysik .
The member class should be `static` if it does not need access to the
enclosing class instance.
If you are interested in it, I suggest trying to read Effective Java(Item
24: Favor static member classes over nonstatic).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
