mbien commented on code in PR #2: URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2#discussion_r1212012881
########## netbeans-jakartaee-war-archetype/src/main/resources/archetype-resources/pom.xml: ########## @@ -0,0 +1,41 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>${groupId}</groupId> + <artifactId>${artifactId}</artifactId> + <version>${version}</version> + <packaging>war</packaging> + + <properties> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <maven.compiler.source>${javaVersion}</maven.compiler.source> + <maven.compiler.target>${javaVersion}</maven.compiler.target> Review Comment: this is pretty cool. I somehow forgot about the fact that maven can run groovy scripts as project creation step. This will likely also allow us to set the right JVM flags for netbeans modules: https://github.com/apache/netbeans/tree/master/nbbuild/jms-config once we update this archetype. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
