dbalek commented on code in PR #6015:
URL: https://github.com/apache/netbeans/pull/6015#discussion_r1214357140
##########
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/WorkspaceServiceImpl.java:
##########
@@ -166,7 +166,9 @@ public final class WorkspaceServiceImpl implements
WorkspaceService, LanguageCli
@Override
public CompletableFuture<Object> executeCommand(ExecuteCommandParams
params) {
- String command = params.getCommand();
+ System.err.println("command before: " + params.getCommand());
Review Comment:
`System.err.println()` should be removed
##########
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/db/DBSetEnvCommand.java:
##########
@@ -44,7 +44,7 @@
*/
@ServiceProvider(service = CodeActionsProvider.class)
public class DBSetEnvCommand extends CodeActionsProvider {
- private static final String COMMAND_SET_DB_ENV = "java.db.set.env";
//NOI18N
+ private static final String COMMAND_SET_DB_ENV = "nbls.java.db.set.env";
//NOI18N
Review Comment:
`nbls.java.db.set.env` -> `nbls.db.set.env` ?
##########
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/db/DBCommandProvider.java:
##########
@@ -44,7 +44,7 @@
*/
@ServiceProvider(service = CodeActionsProvider.class)
public class DBCommandProvider extends CodeActionsProvider {
- private static final String COMMAND_GET_PREFERRED_CONNECTION =
"java.db.preferred.connection";
+ private static final String COMMAND_GET_PREFERRED_CONNECTION =
"nbls.java.db.preferred.connection";
Review Comment:
Consider `nbls.java.db.preferred.connection` ->
`nbls.db.preferred.connection`. Should be similar to `public static final
String DB_ADD_CONNECTION = "nbls.db.add.connection"`
##########
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/htmlui/WebView.java:
##########
@@ -369,7 +369,7 @@ private static Level findLevel(int priority) {
public static final class Server extends CodeActionsProvider {
private static final Map<String, WebView.Command> SESSIONS = new
HashMap<>();
- private static final String PROCESS_COMMAND =
"nb.htmlui.process.command"; // NOI18N
+ private static final String PROCESS_COMMAND =
"nbls.nb.htmlui.process.command"; // NOI18N
Review Comment:
`nbls.nb.htmlui.process.command` -> `nbls.htmlui.process.command`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
