mbien commented on PR #6054: URL: https://github.com/apache/netbeans/pull/6054#issuecomment-1585203316
let me think about this a bit. The netbeans.full.hack property isn't set everywhere, for example if I run `BuildZipDistributionTest` (apisupport/apisupport.ant) in the IDE on JDK 8, it won't work. Adding the property to more tests just to solve this issue here is risky since it changes NB behavior. So I would be slightly in favor for adding a new property which isn't used for anything else and remove it again once the tests are fixed on JDK 11. as a sidenote: the devhack is fairly problematic since it caused already issues more than once ([most recent](https://github.com/apache/netbeans/pull/5530#issuecomment-1442172084)) during PR review where something worked when it was set, but not in release configuration. I would highly recommend to remove it from [here](https://github.com/apache/netbeans/blob/5c5cce4cd16d9f28014fd23df8d57cd05be54f4b/nbbuild/build.properties#L25) when you run test builds or NB from the IDE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
