mbien commented on code in PR #5998:
URL: https://github.com/apache/netbeans/pull/5998#discussion_r1227304507
##########
java/maven/src/org/netbeans/modules/maven/problems/MavenModelProblemsProvider.java:
##########
@@ -90,10 +91,19 @@ public class MavenModelProblemsProvider implements
ProjectProblemsProvider, Inte
private final PropertyChangeSupport support = new
PropertyChangeSupport(this);
private final Project project;
- private final AtomicBoolean projectListenerSet = new AtomicBoolean(false);
- private final AtomicReference<Collection<ProjectProblem>> problemsCache =
new AtomicReference<Collection<ProjectProblem>>();
private final PrimingActionProvider primingProvider = new
PrimingActionProvider();
+
private ProblemReporterImpl problemReporter;
+
+ // @GuardedBy(this)
+ private Pair<Collection<ProjectProblem>, Boolean> problemsCache = null;
+ // @GuardedBy(this)
+ private boolean projectListenerSet;
+
+ /**
+ * The Maven project that has been processed already.
+ */
+ private volatile Reference<MavenProject> analysedProject = new
WeakReference<>(null);
Review Comment:
volatile can be removed, since guarded by this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
