matthiasblaesing commented on code in PR #6028:
URL: https://github.com/apache/netbeans/pull/6028#discussion_r1231237699
##########
platform/core.startup/src/org/netbeans/core/startup/ConsistencyVerifier.java:
##########
@@ -91,7 +99,20 @@ public static SortedMap<String,SortedSet<String>>
findInconsistencies(
"org.openide.modules.os.MacOSX, " + // NOI18N
"org.openide.modules.os.Linux, " + // NOI18N
"org.openide.modules.os.Solaris, " + // NOI18N
- "org.openide.modules.os.OS2"); // NOI18N
+ "org.openide.modules.os.OS2, " + // NOI18N
+ "org.openide.modules.arch.x86_64, " + // NOI18N
+ "org.openide.modules.arch.amd64, " + // NOI18N
+ "org.openide.modules.arch.x86," + // NOI18N
+ "org.openide.modules.arch.aarch64," + // NOI18N
+ "org.openide.modules.arch.arm," + // NOI18N
+ "org.openide.modules.arch.ppc," + // NOI18N
+ "org.openide.modules.arch.ppc64," + // NOI18N
+ "org.openide.modules.arch.ppc64le," + // NOI18N
+ "org.openide.modules.arch.s390x," + // NOI18N
+ "org.openide.modules.arch.zarch_64," + // NOI18N
+ "org.openide.modules.arch.sparc" + // NOI18N
+ "org.openide.modules.arch.sparcv9" + // NOI18N
+ "");
Review Comment:
In general: ConsistencyVerifier is just a test tool. It is not called are
runtime. My understand is, that it checks, that modules are installable as a
group. The `org.openide.modules.os.*` and `org.openide.modules.arch.*` provides
are there, so that these are not taken into account when checking the module
set.
For the architectures: This is basicly a list of all `os.arch` values I'm
aware of ( I just realized, that `loongarch64` is missing). We don't loose
anything if the (or better, the most prominent implementation OpenJDK) does not
support a particular platform and we have the platform in the list. There then
be no module the relies on that value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
