matthiasblaesing commented on code in PR #6081:
URL: https://github.com/apache/netbeans/pull/6081#discussion_r1233333486
##########
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/terraform/TerraformParserResult.java:
##########
@@ -116,8 +122,11 @@ protected void processDocument(HCLDocument doc, SourceRef
references) {
} else {
references.getOffsetRange(type).ifPresent((range) ->
addError(Bundle.UNKNOWN_BLOCK(type.id()), range));
}
+ checkDuplicateAttribute(doc, references);
Review Comment:
This leads to errors reported multiple times. This either needs to be moved
out of the loop (started in new line 101) or doc must become `block`:
```suggestion
checkDuplicateAttribute(block, references);
```
##########
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/FontAndColors.xml:
##########
@@ -36,4 +36,8 @@
<fontcolor name="separator" default="separator"/>
<fontcolor name="string" default="string"/>
<fontcolor name="whitespace" default="whitespace"/>
+
+ <fontcolor name="mod-method" default="keyword">
+ <font style="bold"/>
+ </fontcolor>
Review Comment:
I notice this:
```
SEVERE [org.netbeans.modules.csl.editor.semantic.ColoringManager]: no colors
for: mod-class with mimetext/x-terraform+x-hcl
```
`mod-class` also needs to be added to the colors definition:
```suggestion
<fontcolor name="mod-method" default="keyword">
<font style="bold"/>
</fontcolor>
<fontcolor name="mod-class" default="keyword">
<font style="bold"/>
</fontcolor>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
