jtulach commented on PR #6088: URL: https://github.com/apache/netbeans/pull/6088#issuecomment-1596536752
Thank you for your review, Sváťo. > ancient module and > mixed API/SPI package (e.g. `CloneableOpenSupport`) that depends on Data Systems, > Nodes and other modules irrelevant to text operations. `org.openide.text` doesn't depend on DataSystems. > > This PR reintroduces dependency on My PR doesn't introduce any new dependency - the dependency has already been there and it is not going away anytime soon, as far as I can imagine. > as `NbDocument` resides in `org.openide.text` and we have tried hard to **remove** > dependencies on `org.openide.text` (e.g. by using `LineDocument`). I see, but @sdedic: How do you want to make sure `java.lsp.server` module works even for "plain Swing documents" and not only those provided by NetBeans editor modules? Can you estimate when your plan is implemented? As I need a solution in a foreseeable future. > Invent another ... abstractions There already is `Utils` is `java.lsp.server` module. Isn't that the place to hide abstractions, if we want to have a solution in a timely manner? My PR doesn't spread `import org.openide.text.NbDocument` around the code base - is delegating all the work to `Utils` - isn't that abstracted enough unless we want to spend months on total overhaul of the dependencies system? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
