asbachb commented on code in PR #6112:
URL: https://github.com/apache/netbeans/pull/6112#discussion_r1239965406
##########
enterprise/glassfish.eecommon/src/org/netbeans/modules/glassfish/eecommon/api/DomainEditor.java:
##########
@@ -465,12 +465,12 @@ private String formatJvmOption(String jvmOption) {
static final String[] sysDatasources = {"jdbc/__TimerPool",
"jdbc/__CallFlowPool"}; //NOI18N
- public HashMap<String,Map> getSunDatasourcesFromXml(){
- HashMap<String, Map> dSources = new HashMap<>();
+ public Map<String, Map<String, String>> getSunDatasourcesFromXml(){
+ Map<String, Map<String, String>> dSources = new HashMap<>();
Review Comment:
I don't think this should be "ensured" by the used variable declaration but
by a test. When I expect a method to some kind of generate a SortedMap there
should be a test failing when this behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
