mbien commented on code in PR #6061: URL: https://github.com/apache/netbeans/pull/6061#discussion_r1240102475
########## platform/libs.mockito/external/binaries-list: ########## @@ -0,0 +1,19 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +7CAC313592A29AE5E29C52C22B15C3AE5AB561B2 org.mockito:mockito-core:5.3.1 Review Comment: this might have to be downgraded to 4.x for jdk 8 compatibility (+ whatever bytebuddy version 4.x requires) ########## enterprise/j2ee.common/test/unit/src/org/netbeans/modules/j2ee/common/dd/DDHelperTest.java: ########## Review Comment: would be good to run this new test in CI, feel free to add a `j2ee.common` step analog to https://github.com/apache/netbeans/blob/a7b73e5800d341266f108b486a452ae129dc054b/.github/workflows/main.yml#L1988-L1989 ########## enterprise/j2ee.core/nbproject/org-netbeans-modules-j2ee-core.sig: ########## @@ -26,6 +26,7 @@ CLSS public java.lang.Object cons public init() meth protected java.lang.Object clone() throws java.lang.CloneNotSupportedException meth protected void finalize() throws java.lang.Throwable + anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9") Review Comment: can be removed i think ########## platform/libs.mockito/external/mockito-core-2.15.0-license.txt: ########## Review Comment: wrong version in file name? ########## enterprise/j2ee.common/manifest.mf: ########## @@ -3,4 +3,5 @@ OpenIDE-Module: org.netbeans.modules.j2ee.common/1 OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/j2ee/common/Bundle.properties OpenIDE-Module-Needs: javax.script.ScriptEngine.freemarker OpenIDE-Module-Specification-Version: 1.124 +OpenIDE-Module-Java-Dependencies: Java > 11 Review Comment: can be removed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
