mbien commented on PR #6138: URL: https://github.com/apache/netbeans/pull/6138#issuecomment-1627108817
> the jboss-cli-client brings in a lot of classes that we don't need at all and might be problematic. While I agree that some cleanup should be done in the jars that the classloader relies on I'd rather avoid using that jar. @ehsavoie what classes are you worried about or what is the concern? The server integration is a hack anyway right now. But when compared to what it did before when it cherry picked the classpath: https://github.com/apache/netbeans/blob/faf308b4da5e5f451ba6392f2388b123fa1ab4fa/enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/WildflyDeploymentFactory.java#L241-L255 Simply using the cli jar seems to be a more maintainable approach. Ideally, this all should not be needed if there would be a server independent tooling interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
