mbien commented on code in PR #6150:
URL: https://github.com/apache/netbeans/pull/6150#discussion_r1258408668
##########
java/form/src/org/netbeans/modules/form/JavaCodeGenerator.java:
##########
@@ -2554,6 +2519,84 @@ private void generateListenerAddCode(RADComponent comp,
generateCatchCode(exceptions, codeWriter);
}
+ private void generateInnerClasses(Writer codeWriter, EventSetDescriptor
eventSetDesc, List<Event> eventList, boolean useLambdas) throws IOException {
+
+ if (useLambdas && eventSetDesc.getListenerMethods().length == 1) {
+ generateWithReferenceOrLambda(codeWriter, eventList);
+ } else {
+ codeWriter.write("new "); // NOI18N
+ // try to find adpater to use instead of full listener impl
+ Class listenerType = eventSetDesc.getListenerType();
+ Class adapterClass = BeanSupport.getAdapterForListener(
+ listenerType);
+ if (adapterClass != null) { // use listener adapter class
+ codeWriter.write(getSourceClassName(adapterClass) + "() {\n");
// NOI18N
+
+ for (int i = 0; i < eventList.size(); i++) {
+ Event event = eventList.get(i);
+ String[] paramNames = generateListenerMethodHeader(
+ null, event.getListenerMethod(), codeWriter);
+ generateEventHandlerCalls(event, paramNames, codeWriter,
true);
+ codeWriter.write("}\n"); // NOI18N
+ }
+ } else { // generate full listener implementation (all methods)
+ codeWriter.write(getSourceClassName(listenerType) + "() {\n");
// NOI18N
+
+ Method[] methods = eventSetDesc.getListenerMethods();
+ for (int i = 0; i < methods.length; i++) {
+ Method m = methods[i];
+ Event event = null;
+ for (int j = 0; j < eventList.size(); j++) {
+ Event e = eventList.get(j);
+ if (m.equals(e.getListenerMethod())) {
+ event = e;
+ break;
+ }
+ }
+ String[] paramNames =
+ generateListenerMethodHeader(null, m, codeWriter);
+ if (event != null)
+ generateEventHandlerCalls(event, paramNames,
codeWriter, true);
+ codeWriter.write("}\n"); // NOI18N
+ }
+ }
+ codeWriter.write("}"); // NOI18N
+ }
+ }
+
+ private void generateWithReferenceOrLambda(Writer codeWriter, List<Event>
eventList) throws IOException {
+ if (eventList.get(0).getEventHandlers().length == 1) {
+ codeWriter.append("this::" +
eventList.get(0).getEventHandlers()[0]);
+ } else if (eventList.get(0).getEventHandlers().length > 1) {
+ Class[] paramTypes =
eventList.get(0).getListenerMethod().getParameterTypes();
+ String[] paramNames = generateParamNames(paramTypes);
+ String paramsString = generateParamsString(paramNames);
+
+ codeWriter.append("(");
+ codeWriter.append(paramsString);
+ codeWriter.append(") -> { \n");
Review Comment:
example:
- add a jbutton somwehere
- open properties tab (events section) for that button, add action
performed listener with >1 handler method
This means the handler can't be called via method reference, it should
generate a lambda which calls the event handlers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
