neilcsmith-net commented on code in PR #6213:
URL: https://github.com/apache/netbeans/pull/6213#discussion_r1266772957


##########
java/java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/platformdefinition/J2SEPlatformDefaultJavadocImpl.java:
##########
@@ -116,6 +76,35 @@ public Collection<URI> getDefaultJavadoc(@NonNull final 
JavaPlatform platform) {
         return Collections.emptyList();
     }
 
+    private static String computeJavaDocURL(String version) {
+        switch (version) {
+            case "1.0": // NOI18N
+            case "1.1": // NOI18N
+            case "1.2": // NOI18N
+            case "1.3": // NOI18N
+            case "1.4": return null; // NOI18N
+            case "1.5": return 
"https://docs.oracle.com/javase/1.5.0/docs/api/";; // NOI18N
+            case "1.6": return "https://docs.oracle.com/javase/6/docs/api/";; 
// NOI18N
+            case "1.7": return "https://docs.oracle.com/javase/7/docs/api/";; 
// NOI18N
+            case "1.8": return "https://docs.oracle.com/javase/8/docs/api/";; 
// NOI18N
+        }
+        try {
+            int feature = Integer.parseInt(version);
+            if (feature >= 9) {
+                // timezone shouldn't matter since the accuracy is worse than 
a day
+                LocalDate jdk9 = LocalDate.of(2017, Month.SEPTEMBER, 21); // 
start of 6 month schedule
+                long max = ChronoUnit.MONTHS.between(jdk9, LocalDate.now()) / 
6 + 9;

Review Comment:
   @mbien to be clear, I'm fine with date based for now.  A proper API that 
gives the maximum supported JDK by the current IDE configuration would be 
useful.  Mind you, maybe assuming everything up to `SourceVersion.latest()` is 
GA? Still, I do get your point about pinging.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to