tmysik commented on code in PR #6241:
URL: https://github.com/apache/netbeans/pull/6241#discussion_r1271000517
##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/ui/DbgpLineBreakpointCustomizerPanel.java:
##########
@@ -184,6 +198,22 @@ public Controller getController() {
return controller;
}
+ private static int findNumLines(FileObject file) {
+ DataObject dataObject;
+ try {
+ dataObject = DataObject.find (file);
+ } catch (DataObjectNotFoundException ex) {
+ return 0;
+ }
+ EditorCookie ec = (EditorCookie)
dataObject.getCookie(EditorCookie.class);
+ if (ec == null) return 0;
+ ec.prepareDocument().waitFinished();
+ Document d = ec.getDocument();
+ if (!(d instanceof StyledDocument)) return 0;
Review Comment:
Please, use better variable names than just `ec`, `ed` or `d`. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
