mbien commented on code in PR #6344:
URL: https://github.com/apache/netbeans/pull/6344#discussion_r1295271172


##########
java/maven.embedder/src/org/netbeans/modules/maven/embedder/MavenEmbedder.java:
##########
@@ -367,6 +373,7 @@ public ArtifactRepository createRemoteRepository(String 
url, String id) {
      * @param localRepository
      * @throws ArtifactResolutionException
      * @throws ArtifactNotFoundException 
+     * @deprecated the Maven API used swallows certain {@link 
ArtifactNotFoundException} and does not report properly to the caller. Use 
{@link #resolveArtifact} instead.
      */
     public void resolve(Artifact sources, List<ArtifactRepository> 
remoteRepositories, ArtifactRepository localRepository) throws 
ArtifactResolutionException, ArtifactNotFoundException {

Review Comment:
   please add the` @Deprecated` annotation too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to