junichi11 commented on code in PR #6366:
URL: https://github.com/apache/netbeans/pull/6366#discussion_r1300928928
##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/BreakpointsReader.java:
##########
@@ -34,14 +34,16 @@ public class BreakpointsReader implements Properties.Reader
{
private static final String ENABED = "enabled"; // NOI18N
private static final String FUNC_NAME = "functionName"; // NOI18N
+ private static final String EXCEPTION_NAME = "exceptionName"; // NOI18N
private static final String TYPE = "type"; // NOI18N
private static final String GROUP_NAME = "groupName"; // NOI18N
@Override
public String[] getSupportedClassNames() {
return new String[]{
LineBreakpoint.class.getName(),
- FunctionBreakpoint.class.getName()
+ FunctionBreakpoint.class.getName(),
+ ExceptionBreakpoint.class.getName()
Review Comment:
Maybe, should move to a field?
e.g.
```java
private static final String[] SUPPORTED_CLASS_NAMES = ...;
public String[] getSupportedClassNames() {
return SUPPORTED_CLASS_NAMES;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
