tmysik commented on code in PR #6366:
URL: https://github.com/apache/netbeans/pull/6366#discussion_r1302770953
##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/BreakpointModel.java:
##########
@@ -119,15 +126,25 @@ public String getShortDescription(Object node) throws
UnknownTypeException {
public void setCurrentStack(Stack stack, DebugSession session) {
if (stack == null) {
- synchronized (myCurrentBreakpoints) {
- AbstractBreakpoint breakpoint =
myCurrentBreakpoints.remove(session);
- fireChangeEvent(new ModelEvent.NodeChanged(this, breakpoint));
- }
+ removeCurrentBreakpoint(session);
Review Comment:
Nitpick: This line can be moved inside the `synchronized` block above (it
uses the same lock, so it would avoid the situation where we get the lock,
release the lock and get the lock again).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
