junichi11 commented on code in PR #6241:
URL: https://github.com/apache/netbeans/pull/6241#discussion_r1302938235


##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/ui/DbgpLineBreakpointCustomizerPanel.java:
##########
@@ -184,6 +202,28 @@ public Controller getController() {
         return controller;
     }
 
+    private static int findNumLines(FileObject file) {
+        DataObject dataObject;
+        try {
+            dataObject = DataObject.find(file);
+        } catch (DataObjectNotFoundException ex) {
+            LOGGER.log(Level.WARNING, "Can''t find DataObject for {0}", 
file.getPath()); // NOI18N

Review Comment:
   IMHO, maybe, we should not translate it. If translated, we may not 
understand what it means when we receive an issue with a log...  e.g. 
”データオブジェクトがみつかりません”



##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/ui/DbgpLineBreakpointCustomizerPanel.java:
##########
@@ -184,6 +202,28 @@ public Controller getController() {
         return controller;
     }
 
+    private static int findNumLines(FileObject file) {
+        DataObject dataObject;
+        try {
+            dataObject = DataObject.find(file);
+        } catch (DataObjectNotFoundException ex) {
+            LOGGER.log(Level.WARNING, "Can''t find DataObject for {0}", 
file.getPath()); // NOI18N

Review Comment:
   IMHO, maybe, we should not translate it. If translated, we may not 
understand what it means when we receive an issue with a log...  e.g. 
”データオブジェクトがみつかりません”



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to