matthiasblaesing commented on PR #6480: URL: https://github.com/apache/netbeans/pull/6480#issuecomment-1732350016
The approach to update commons-io looks sane to me. It seems cleaner than the alternative suggestion in #3794, where I overlooked, that supporting "-" in the module name would need further work. A test build seems to work ok (build maven project, modified maven dependencies, used update version hint in pom). I see sometimes flaky behavior in this area, but that is not tied to this change. The change was tested together with the JDOM update in #6478. The change to the binaries-list: https://github.com/apache/netbeans/blob/c4da5b2300a533eadf165639c047dbbcc64fa4a6/extide/o.apache.tools.ant.module/external/binaries-list#L17 seems ok. But has drawbacks. For maven central the CDN backing it is pretty good in my experience. We need to see how stable the netbeans archive server is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
