mbien commented on code in PR #6493:
URL: https://github.com/apache/netbeans/pull/6493#discussion_r1337690847
##########
java/maven.hints/src/org/netbeans/modules/maven/hints/pom/UpdateDependencyHint.java:
##########
@@ -109,10 +110,15 @@ private void addHintsTo(List<? extends
VersionablePOMComponent> components, Map<
for (VersionablePOMComponent comp : components) {
- String groupId = comp.getGroupId();
- String artifactId = comp.getArtifactId();
+ String groupId = comp.getGroupId() != null &&
!comp.getGroupId().isBlank() ? comp.getGroupId() : null;
+ String artifactId = comp.getArtifactId() != null &&
!comp.getArtifactId().isBlank() ? comp.getArtifactId() : null;
- if (groupId != null && artifactId != null && !groupId.isEmpty() &&
!artifactId.isEmpty()) {
+ // no group ID could indicate it is a default maven plugin
+ if (comp instanceof Plugin && groupId == null && artifactId !=
null && artifactId.startsWith("maven-")) {
Review Comment:
good suggestions, will change it! I forgot that report plugins existed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
