[GitHub] [netbeans] bitrunner commented on a diff in pull request #6440: [cnd] add C17, C23, C++20, C++23 language standards

[via GitHub]

bitrunner commented on code in PR #6440:
URL: https://github.com/apache/netbeans/pull/6440#discussion_r1342268924


##########
cnd/cnd.lexer/src/org/netbeans/cnd/api/lexer/CndLexerUtilities.java:
##########
@@ -448,12 +448,16 @@ public static Filter<?> getFilter(Language<?> language, 
/*can be null*/CndLangua
                     case C89:
                     case C99:
                     case C11:
+                    case C17:
+                    case C23:
                         return CndLexerUtilities.getHeaderC11Filter();
                     case CPP98:
                         return CndLexerUtilities.getHeaderCppFilter();
                     case CPP11:
                     case CPP14:
                     case CPP17:
+                    case CPP20:
+                    case CPP23:

Review Comment:
   Thanks for taking the time to review this!
   
   I thought the CND lexer was obsolete after the switch to LSP.  If that's not 
the case, I can take a crack at updating the tokens too based on [cpp 
reference](https://en.cppreference.com/w/cpp/keyword).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists