neilcsmith-net commented on code in PR #6513: URL: https://github.com/apache/netbeans/pull/6513#discussion_r1343111970
########## ide/dlight.nativeexecution/tools/Makefile: ########## @@ -32,8 +32,8 @@ CF_Linux-x86_64 = -DLINUX -D_GNU_SOURCE -D_XOPEN_SOURCE=700 -m64 CF_Linux-sparc_64 = -DLINUX -D_GNU_SOURCE -D_XOPEN_SOURCE=700 -m64 CF_Linux-arm = -DLINUX -D_GNU_SOURCE -D_XOPEN_SOURCE=700 -std=c99 CF_Linux-aarch64 = -DLINUX -D_GNU_SOURCE -D_XOPEN_SOURCE=700 -std=c99 -CF_MacOSX-x86 = -DMAXOSX -D_DARWIN_C_SOURCE -m32 -CF_MacOSX-x86_64 = -DMAXOSX -D_DARWIN_C_SOURCE -m64 +CF_MacOSX-arm = -DMAXOSX -D_DARWIN_C_SOURCE -target arm64-apple-macos Review Comment: Ah, ok, something to look at later. This change is based on @oyarzun suggestion. It works to compile until we get Apple Silicon runners, which should be soon. Ideally I think we would move to having a single, universal binaries for these with macOS anyway? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
