sdedic commented on code in PR #6516:
URL: https://github.com/apache/netbeans/pull/6516#discussion_r1343567503
##########
extide/gradle/apichanges.xml:
##########
@@ -83,6 +83,21 @@ is the proper place.
<!-- ACTUAL CHANGES BEGIN HERE: -->
<changes>
+ <change id="gradle-setting-deprecation">
+ <api name="general"/>
+ <summary>Some Gradle Settings Removed from Use</summary>
+ <version major="2" minor="36"/>
+ <date day="2" month="10" year="2023"/>
+ <author login="lkishalmi"/>
+ <compatibility semantic="compatible" />
Review Comment:
IMHO semantic should be `incompatible`: code that hopes the setter (setting)
has some effect may break.
##########
extide/gradle/src/org/netbeans/modules/gradle/spi/GradleSettings.java:
##########
@@ -182,12 +185,24 @@ public File getGradleUserHome() {
return dir != null ? new File(dir) : new
File(System.getProperty("user.home"), ".gradle"); //NOI18N
}
+ /**
+ * Not in use.
+ * @param b
+ * @deprecated
+ */
+ @Deprecated
Review Comment:
Consider to log a `WARNING`-level message in the setters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
