matthiasblaesing commented on PR #6544: URL: https://github.com/apache/netbeans/pull/6544#issuecomment-1751970782
There were questions raised in the base PR (#6500) regarding NetBeans OSGI support (I think @mbien and @neilcsmith-net were involved): - **Can the NetBinox OSGI integration handle Multi-Release JARs?**: I tested this with a manually built OSGI jar, where I created a bundle activator, that reported a number. The reported value matched the implementation located in `META-INF/versions/17`. - **Is the OSGI `Fragment-Host` header support?**: JGit relies on the Fragment-Host header for JSch and OpenPGP support. Both were manually verified. The questions about OSGI integration support for NetBeans are valid though as two limitations were found and had to be fixed: - The parsing of the `Fragment-Host` header did not account for bundle specifications with version constraints. To fix this the code already used when parsing the `Export-Package` was also applied for the `Fragment-Host`. - JGit declares a dependency on the runtime java version via the `Bundle-RequiredExecutionEnvironment` header. This is checked against the list of values present in `org.osgi.framework.executionenvironment` by the OSGI runtime. This value was basicly fixed on the one matching JDK 8 in Equinox. To support later JDKs the value of `org.osgi.framework.executionenvironment` is now calculated by the NetBinox infrastructure before the OSGI framework is initialized. @jtulach I think you are best qualified to review the OSGI/NetBinox changes. Could you please have a look at d32a76e785757b0c3382a120be90550f00a3b1bb and 7ff7e8787f4a932d5d5902dbe6b38645dfa7755f? With regard to https://github.com/apache/netbeans/issues/4439 we need to implement an CredentialsProvider, that dispatches display/querying of data to Swing and integrates with the NetBeans KeyRing. The GitCommand subclasses need to be modified to set that provider. I injected a test implementation that returned a hard coded passphrase and that enabled me to create a signed commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
