sdedic commented on PR #6541:
URL: https://github.com/apache/netbeans/pull/6541#issuecomment-1754599743
I don't like the solution - while it hides opening brace, it shows the
paired one. In addition, folding itself is not blocked - one can do CTRL+ plus
on a folded method's declaration (modifiers, name) to unfold.
So the really buggy thing is just the indicator (appearance) and its
handling.
I would suggest to add a different indicator in this case, to signal that
both operations are possible. In addition, if the expand sign handler just
gives a preference to "expand" (now it prefers collapse, if there are more
options on the same line), it could be satisfactory. If not, then I suggest to
enhance the handler so that it recognizes some modifier (shift ?) and od expand
or collapse, depending on it.
I've just briefly checked IntelliJ and vscode.
- IntelliJ shows just "expand" marker if there are both collapsed and
expanded fold regions on the line. Clicking it expands the 1st folded region
- vscode leaves BOTH {} visible, replaces just the content.
I'd prefer the IntelliJ way :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
