matthiasblaesing commented on code in PR #6502:
URL: https://github.com/apache/netbeans/pull/6502#discussion_r1355725664
##########
.gitignore:
##########
@@ -69,6 +69,8 @@ derby.log
/ide/db.sql.visualeditor/src/org/netbeans/modules/db/sql/visualeditor/parser/TokenMgrError.java
/profiler/lib.profiler/release/lib/
/profiler/lib.profiler/release/BUILDINFO.txt
+/profiler/lib.profiler/release/LICENSE
+/profiler/lib.profiler/release/NOTICE
Review Comment:
With suggestion for change in `build.xml` these three ignores can be removed.
##########
profiler/lib.profiler/build.xml:
##########
@@ -34,6 +34,10 @@
<unzip
src="external/profiler-external-binaries-ASF-5273a10f9471d5cf60ed894dc26ec0e59e71cc24.zip"
overwrite="true"
dest="${profiler.cluster}"/>
+ <!-- AL2 licensed binaries, newer build from ASF code -->
+ <unzip src="external/profiler-external-binaries-1-24aefa9.zip"
+ overwrite="true"
+ dest="${profiler.cluster}"/>
Review Comment:
```suggestion
<unzip src="external/profiler-external-binaries-1-24aefa9.zip"
overwrite="true"
dest="${profiler.cluster}">
<!-- Only extract lib folder (licenses, notices are covered by
project wide license/notice) -->
<patternset>
<include name="lib/**"/>
</patternset>
</unzip>
```
##########
profiler/lib.profiler/external/binaries-list:
##########
@@ -16,3 +16,4 @@
# under the License.
45225DCFC94A9782419E95C70957822A0C44612D profiler-external-binaries-8.2.zip
B1C1B951F79716EFFAB9BEC96A611844B038E2E2
profiler-external-binaries-ASF-5273a10f9471d5cf60ed894dc26ec0e59e71cc24.zip
Review Comment:
With comment from `build.xml` this line can be dropped.
##########
profiler/lib.profiler/build.xml:
##########
@@ -34,6 +34,10 @@
<unzip
src="external/profiler-external-binaries-ASF-5273a10f9471d5cf60ed894dc26ec0e59e71cc24.zip"
overwrite="true"
dest="${profiler.cluster}"/>
Review Comment:
This can be removed. At least if I'm not totally mistaken
`profiler-external-binaries-ASF-5273a10f9471d5cf60ed894dc26ec0e59e71cc24.zip`
holds the same set of files, that `profiler-external-binaries-1-24aefa9.zip`
holds and the latter is unzipped with `overwrite=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
